feat: init SeedlessOnboardingController via @metamask/wallet - #33413

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

PR template — items to address before "Ready for review"

Warnings — informational, address before merging:

• Pre-merge author checklist has unchecked items (e.g. "I've tested on Android"). Every box must be consciously checked — see docs/readme/ready-for-review.md.

See docs/readme/ready-for-review.md for the full Definition of Ready for Review.

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	npm/​@​metamask/​wallet@​7.0.1 ⏵ 8.0.0	+1		+1	+1
	npm/​@​metamask/​seedless-onboarding-controller@​10.0.3 ⏵ 10.1.0	+1		+1

View full report

🧪 Flaky unit test detection

Run history flaky detection

View recent run history

Historical failure rate is a hint, not proof — review each suggestion in context. See the flaky-test-detection skill for the full pattern reference and manual audit workflow.

Failures / runs sampled per window:

AI-detected flaky patterns

app/core/Engine/wallet-init/instance-options/seedless-onboarding-controller.test.ts

• J3 — Missing jest.clearAllMocks() / jest.resetAllMocks() (high)
  • Both describe blocks have a beforeEach that re-sets mock implementations via .mockResolvedValue(...), but neither calls jest.clearAllMocks() first. This means call counts and call argument histories from previous tests accumulate across all tests in the suite. Every test that asserts toHaveBeenCalledWith(...) (e.g. the encryptWithKey, decryptWithKey, decrypt, and decryptWithDetail tests) is implicitly relying on the mock having been called exactly once — but if test execution order changes (e.g. via --randomize) or a prior test in the same describe block also invoked the same mock, the call history will contain extra entries. This can cause toHaveBeenCalledWith to match a stale call from a prior test, masking a real failure, or cause toHaveBeenCalledTimes assertions (if added) to fail. Adding jest.clearAllMocks() at the top of each beforeEach eliminates this risk by resetting call counts and argument histories before every test while still allowing the mockResolvedValue calls below it to set fresh implementations.
  • Suggested fix in app/core/Engine/wallet-init/instance-options/seedless-onboarding-controller.test.ts:83:

    -  beforeEach(() => {
    -    const {
    -      mockEncryptWithKey,
    -      mockDecryptWithKey,
    -      mockDecrypt,
    -      mockDecryptWithDetail,
    -    } = getEncryptorMocks();
    -    mockEncryptWithKey.mockResolvedValue(mockEncryptResult);
    -    mockDecryptWithKey.mockResolvedValue({ test: 'decrypted-data' });
    -    mockDecrypt.mockResolvedValue({ test: 'decrypted-data' });
    -    mockDecryptWithDetail.mockResolvedValue({
    -      vault: { test: 'decrypted-data' },
    -      exportedKeyString: 'key',
    -    });
    -  });
    +  beforeEach(() => {
    +    jest.clearAllMocks();
    +    const {
    +      mockEncryptWithKey,
    +      mockDecryptWithKey,
    +      mockDecrypt,
    +      mockDecryptWithDetail,
    +    } = getEncryptorMocks();
    +    mockEncryptWithKey.mockResolvedValue(mockEncryptResult);
    +    mockDecryptWithKey.mockResolvedValue({ test: 'decrypted-data' });
    +    mockDecrypt.mockResolvedValue({ test: 'decrypted-data' });
    +    mockDecryptWithDetail.mockResolvedValue({
    +      vault: { test: 'decrypted-data' },
    +      exportedKeyString: 'key',
    +    });
    +  });

This check is informational only and does not block merging.

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeSwap, SmokeStake, SmokeWalletPlatform, SmokeMoney, SmokePerps, SmokeMultiChainAPI, SmokePredictions, SmokeSeedlessOnboarding, SmokeSeedlessOnboardingExtended, SmokeBrowser, SmokeSnaps, SmokeMMConnect
• Selected Performance tags: @PerformanceOnboarding, @PerformanceLogin
• Risk Level: high
• AI Confidence: 100%

View GitHub Actions results

❌ E2E Fixture Validation — Failed
The fixture validation job failed. Review the logs

⚡ Performance Test Results

ℹ️ Performance test results are currently non-blocking and will not block this PR.

❌ 12 tests failed · 12 tests · 1 device

❌ Failed Tests (12)

🔬 To compare BrowserStack app profiling vs the last green run on main, copy/paste the App profiling check command for a failed test as a PR comment.

@assets-dev-team

@metamask-mobile-platform

@metamask-onboarding-team

Branch: feat/TO-921-wallet-init-seedless · Build: Normal · Commit: d43841a · View full run

Closing as as changes merged in PR: #33430